From c3ac45e0c186b0d6a6064f4ff5ab8f7f8017cc3b Mon Sep 17 00:00:00 2001
From: Nathan Lamy <nathan.lamycharrier@gmail.com>
Date: Wed, 25 Feb 2026 00:04:44 +0100
Subject: [PATCH] feat: add firstName and lastName

---
 app/models/user.ts | 29 ++++++++++++++++++++++++-----
 1 file changed, 24 insertions(+), 5 deletions(-)

diff --git a/app/models/user.ts b/app/models/user.ts
index 2af279e..7919e38 100644
--- a/app/models/user.ts
+++ b/app/models/user.ts
@@ -9,7 +9,7 @@ export default class User extends BaseModel {
   serialize() {
     const ctx = HttpContext.get()
 
-    if (!ctx || !ctx.request.url().startsWith('/users')) {
+    if (!ctx) {
       this.serializeExtras = false
       const serialized = super.serialize()
       delete serialized.pastStudentId
@@ -17,11 +17,30 @@ export default class User extends BaseModel {
       return serialized
     }
 
-    this.serializeExtras = true
-    return {
-      ...super.serialize(),
-      preferences: this.preferences,
+    const requestUrl = ctx.request.url()
+    const isUsersRoute = requestUrl.startsWith('/users')
+    const isMeRoute = requestUrl === '/users/@me'
+
+    this.serializeExtras = isUsersRoute
+
+    const serialized = super.serialize()
+    if (!isUsersRoute) {
+      delete serialized.pastStudentId
+      delete serialized.extras
     }
+
+    if (isMeRoute) {
+      serialized.firstName = this.firstName
+      serialized.lastName = this.lastName
+    }
+
+    if (this.serializeExtras) {
+      serialized.preferences = this.preferences
+    } else {
+      delete serialized.preferences
+    }
+
+    return serialized
   }
 
   static rememberMeTokens = DbRememberMeTokensProvider.forModel(User)